- Sep 21, 2021
-
-
Stein Magne Bjorklund authored
-
Stein Magne Bjorklund authored
- Make match method testable.
-
Stein Magne Bjorklund authored
- Class is immutable and this returns a new object with the new configuration. This allows us during bootstrap to change this before passing it to loadspkr modules.
-
Stein Magne Bjorklund authored
- Make class use of config more predicable by stop using global conf. - Make the class vital methods more testable.
-
Stein Magne Bjorklund authored
- Allow us to inject a configuration to class and enable us to test it before refactoring.
-
Stein Magne Bjorklund authored
-
Stein Magne Bjorklund authored
-
Stein Magne Bjorklund authored
Makes it easier to replace the use of global throughout the code.
-
- Sep 20, 2021
-
-
Stein Magne Bjorklund authored
-
Stein Magne Bjorklund authored
-
Stein Magne Bjorklund authored
- Reformatting - Error 500 exits. Will never return.
-
Stein Magne Bjorklund authored
- Easier to maintain without all errors.
-
Stein Magne Bjorklund authored
-
Stein Magne Bjorklund authored
-
Stein Magne Bjorklund authored
-
Stein Magne Bjorklund authored
-
Stein Magne Bjorklund authored
-
Stein Magne Bjorklund authored
-
Stein Magne Bjorklund authored
-
Stein Magne Bjorklund authored
-
Stein Magne Bjorklund authored
Enable us to replace global states.
-
Stein Magne Bjorklund authored
-
Stein Magne Bjorklund authored
- Inject this into the needed classes and get away from globals.
-
Stein Magne Bjorklund authored
-
Stein Magne Bjorklund authored
-
Stein Magne Bjorklund authored
Do not implement properties or code. It is a interface and should be typed as one.
-
Stein Magne Bjorklund authored
- Also remove extra include of settings. No longer needed.
-
Stein Magne Bjorklund authored
- Composer PSR-4 autoloading.
-
Stein Magne Bjorklund authored
- Reduce logic complexity. - Return early. Code get called on every request and should be fast. - Remove support for mirroring multiple uri. Code uses a long gone PHP function. Split this into a private method.
-
Stein Magne Bjorklund authored
- Also require the file. Force it to fail hard if not found.
-
Stein Magne Bjorklund authored
Cleanup that improve code readability.
-
Stein Magne Bjorklund authored
-
Stein Magne Bjorklund authored
First thing application do is loading the settings making sure that it is available.
-
Stein Magne Bjorklund authored
-
Stein Magne Bjorklund authored
-
Stein Magne Bjorklund authored
We cannot just remove data from common.inc.php The class expect and try to use it throwing errors/warning every time the application load.
-
- Sep 15, 2021
-
-
Stein Magne Bjorklund authored
- No need to waste time calling Utils::uri2curie()
-
Stein Magne Bjorklund authored
- Use PSR-4 autoloading - Clean up code and reduce complexity.
-
Stein Magne Bjorklund authored
- Paves way for real autoloading in the future.
-
Stein Magne Bjorklund authored
- Always called utilities. We need to make sure they work as expected. Introduce PHPUnit tests. - Due to the use of gobals inside the static methods they become untestable. Remove use of global but that also forces a change if method signature.
-