Heuristic for telling if guest is registered and verified

This adds is_registered() -> bool and is_verified() -> bool to the Person model. These are, respectively, convenience methods for telling if they have completed the guest registration (filled in the forms, accepted consent forms, &c.), and for telling if the guest has a valid identity associated with them.

A valid identification method is any one of PersonIdentity.IdentityType with a verified_when attribute set in the past. Future identity checks are considered illegal. If the identity has not been verified (verified_when has not been set), the identification method is considered invalid, and is_verified() will return false. It is possible that we may want to consider some identity types automatically valid at this point, but this has not been encoded into this changset.

If the guest has multiple identities associated with them, is_verified() will return true if at least one of them has been verified. This means a guest can have both verified and unverified identities associated with them, but that only one is required to be verified for the guest to be considered verified.

The combination of is_registered() and is_verified() are meant to signal that the guest is cleared for having an account created in the IGA. GREG should use person.is_registered() and person.is_verified() to gate whether to issue notifications to the IGA.

See the individuals commit messages for implementation details.

greg/tests/models/test_person.py

@@ -87,6 +87,19 @@ def passport(a_year_ago: datetime) -> PersonIdentity:
     )
 
 
+@pytest.fixture
+def unverified_passport() -> PersonIdentity:
+    return PersonIdentity(type=PersonIdentity.IdentityType.PASSPORT)
+
+
+@pytest.fixture
+def future_identity(a_year_into_future: datetime) -> PersonIdentity:
+    return PersonIdentity(
+        type=PersonIdentity.IdentityType.NATIONAL_ID_CARD,
+        verified_when=a_year_into_future,
+    )
+
+
 @pytest.fixture
 def feide_verified(person: Person, feide_id: PersonIdentity) -> Person:
     person.identities.add(feide_id, bulk=False)
@@ -125,3 +138,40 @@ def test_is_registered_completed_in_past(person, a_year_ago):
 def test_is_registered_completed_in_future(person, a_year_into_future):
     person.registration_completed_date = a_year_into_future
     assert not person.is_registered
+
+
+@pytest.mark.django_db
+@pytest.mark.parametrize("identity_type", PersonIdentity.IdentityType)
+def test_is_verified(identity_type, a_year_ago, person):
+    identity = PersonIdentity(type=identity_type, verified_when=a_year_ago)
+    person.identities.add(identity, bulk=False)
+    assert person.is_verified
+
+
+@pytest.mark.django_db
+def test_is_verified_multiple_identities(person, feide_id, passport):
+    person.identities.add(feide_id, passport, bulk=False)
+    assert person.is_verified
+
+
+@pytest.mark.django_db
+def is_verified_when_identity_is_unverified(person, unverified_passport):
+    person.identities.add(unverified_passport, bulk=False)
+    assert not person.is_verified
+
+
+@pytest.mark.django_db
+def is_verified_mixed_verified_and_unverified_identities(
+    person,
+    feide_id,
+    unverified_passport,
+    future_identity,
+):
+    person.identities.add(feide_id, unverified_passport, future_identity, bulk=False)
+    assert person.is_verified
+
+
+@pytest.mark.django_db
+def is_verified_in_future(person, future_identity):
+    person.identities.add(future_identity, bulk=False)
+    assert not person.is_verified