Add a few more role types to fixtures

greg/tests/populate_fixtures.py

@@ -44,8 +44,10 @@ from greg.models import (
 )
 
 
-ROLE_TYPE_EXT_SCI = "extsci"
+ROLE_TYPE_GUEST_RESEARCHER = "guest-researcher"
 ROLE_TYPE_EMERITUS = "emeritus"
+ROLE_TYPE_EXTERNAL_CONSULTANT = "external-consultant"
+ROLE_TYPE_EXTERNAL_PARTNER = "external-partner"
 TESTDATA_SOURCE = "testsource"
 SPONSOR_FEIDEID = "sponsor@feide.no"
 OU_EUROPE_NAME_EN = "Europe"
@@ -146,20 +148,34 @@ class DatabasePopulation:
 
     def _add_roletypes(self):
         RoleType.objects.create(
-            identifier=ROLE_TYPE_EXT_SCI,
+            identifier=ROLE_TYPE_GUEST_RESEARCHER,
             name_nb="Gjesteforsker",
             name_en="Guest researcher",
-            description_nb="Gjesteforsker som ikke skal ha lønn",
-            description_en="Guest reasearcher without payment",
+            description_nb="Forsker som ikke er lønnet av UiO",
+            description_en="Researchers who are not paid by UiO",
         )
         RoleType.objects.create(
             identifier=ROLE_TYPE_EMERITUS,
             name_nb="Emeritus",
             name_en="Emeritus",
-            description_nb="Emeritus",
-            description_en="Emeritus",
+            description_nb="Ansatt som har gått av med pensjon",
+            description_en="A retired employee",
             max_days=700,
         )
+        RoleType.objects.create(
+            identifier=ROLE_TYPE_EXTERNAL_CONSULTANT,
+            name_nb="Ekstern konsulent",
+            name_en="External consultant",
+            description_nb="Person som UiO ikke lønner direkte",
+            description_en="A person that UiO does not pay directly",
+        )
+        RoleType.objects.create(
+            identifier=ROLE_TYPE_EXTERNAL_PARTNER,
+            name_nb="Ekstern partner",
+            name_en="External partner",
+            description_nb="Person som ikke er lønnet av UiO",
+            description_en="A person that is not paid by UiO",
+        )
 
     def _add_sponsors(self):
         """Add a sponsor connected to the Europe unit"""
@@ -179,7 +195,7 @@ class DatabasePopulation:
         iggy = Person.objects.create(first_name="Iggy", last_name="Invited")
         role = Role.objects.create(
             person=iggy,
-            type=RoleType.objects.get(identifier=ROLE_TYPE_EXT_SCI),
+            type=RoleType.objects.get(identifier=ROLE_TYPE_GUEST_RESEARCHER),
             orgunit=OrganizationalUnit.objects.get(name_en=OU_EUROPE_NAME_EN),
             start_date=datetime.date.today() + datetime.timedelta(days=2),
             end_date=datetime.date.today() + datetime.timedelta(days=100),
@@ -206,7 +222,7 @@ class DatabasePopulation:
         )
         role = Role.objects.create(
             person=walter,
-            type=RoleType.objects.get(identifier=ROLE_TYPE_EXT_SCI),
+            type=RoleType.objects.get(identifier=ROLE_TYPE_GUEST_RESEARCHER),
             orgunit=OrganizationalUnit.objects.get(name_en=OU_EUROPE_NAME_EN),
             start_date=datetime.date.today() - datetime.timedelta(days=30),
             end_date=datetime.date.today() + datetime.timedelta(days=100),
@@ -239,7 +255,7 @@ class DatabasePopulation:
         )
         role = Role.objects.create(
             person=adam,
-            type=RoleType.objects.get(identifier=ROLE_TYPE_EXT_SCI),
+            type=RoleType.objects.get(identifier=ROLE_TYPE_GUEST_RESEARCHER),
             orgunit=OrganizationalUnit.objects.get(name_en=OU_EUROPE_NAME_EN),
             start_date=datetime.date.today() - datetime.timedelta(days=30),
             end_date=datetime.date.today() + datetime.timedelta(days=100),
@@ -289,7 +305,7 @@ class DatabasePopulation:
         )
         role = Role.objects.create(
             person=esther,
-            type=RoleType.objects.get(identifier=ROLE_TYPE_EXT_SCI),
+            type=RoleType.objects.get(identifier=ROLE_TYPE_GUEST_RESEARCHER),
             orgunit=OrganizationalUnit.objects.get(name_en=OU_EUROPE_NAME_EN),
             start_date=datetime.date.today() - datetime.timedelta(days=200),
             end_date=datetime.date.today() - datetime.timedelta(days=100),