Update view option visibility

Update the visibility for the view section in create discussion
to only display it if the user have a 'can moderate' permission
and not based on the role

closes VICE-5025

flag=discussion_default_sort,discussion_default_expand

Test plan:
- In the new discussion based on the permission display the
view settings
- (in default) as a teacher should see it
- a student shouldn't
- mascareding a student should show it
- clicking on the view as student on discussion page, the options
should be also hidden

Change-Id: Iee699323766745e5698576e9271a5396ccc359fa
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/370181


Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Theo Sorriaux <theo.sorriaux@instructure.com>
QA-Review: Roland Beres <roland.beres@instructure.com>
Product-Review: Balint Kartyas <balint.kartyas@instructure.com>

ui/features/discussion_topic_edit_v2/react/util/constants.jsx

@@ -99,7 +99,7 @@ export const useShouldShowContent = (
       ENV.allow_student_anonymous_discussion_topics)
 
   const shouldShowViewSettings =
-    !isStudent &&
+    ENV.DISCUSSION_TOPIC?.PERMISSIONS?.CAN_MODERATE &&
     !isAnnouncement &&
     (ENV.DISCUSSION_DEFAULT_EXPAND_ENABLED || ENV.DISCUSSION_DEFAULT_SORT_ENABLED)