WP143 it/site/w4.uib.no#1614 Normalize user data and enhance SCIM validation.
Merged
requested to merge 1614-wp143-match-camel-case-and-lower-case-email-addresses-on-login-with-feide into master
All threads resolved!
Ensure 'preferred_username' and 'email' are lowercase for consistency. Add a null check to SCIM data retrieval to improve validation reliability.
Merge request reports
Activity
Filter activity
assigned to @steinmb
added 4 commits
-
e70925c3...8b63ee3e - 3 commits from branch
master - 5c439807 - WP143 #1624 Normalize user data and enhance SCIM validation.
-
e70925c3...8b63ee3e - 3 commits from branch
requested review from @arejo
added 1 commit
- 3add1363 - WP143 #1614 Normalize user data and enhance SCIM validation.
A couple of comments:
- The SCIM validation is not needed. It will never be executed unless someone puts a value into the field which soon will be removed from the site along with the code trying to use the data from the field.
- The natural place for altering the e-mail from feide would be in uib_feide_openid_connect_userinfo_alter(). This is executed ahead of uib_feide_openid_connect_pre_authorize() if I am not mistaken.
added 1 commit
- 616247bc - WP143 # 1614 Refactor userinfo alteration and fix SCIM connector
- Resolved by Sven Berg Ryen
If the claim eduPersonPrincipalName is not set (and it may not) the email will not be lowercased. Actually we do not need to lowercase the preferred_username. eduPersonPrincipalName is always delivered in lowercase from Feide (according to the documentation). Email is not.
- Last reply by Sven Berg Ryen
assigned to @Sven.B.Ryen and unassigned @arejo
added 1 commit
- 7c8f6fdb - WP143 #1614 Normalize email case in OpenID Connect userinfo context.
Please register or sign in to reply