Skip to content
Snippets Groups Projects
Commit 02a765a5 authored by Stein Magne Bjorklund's avatar Stein Magne Bjorklund
Browse files

WP143: #1362: ConfigUibOverride missing interface implimentations

 - Method Drupal\uib_common_ui\Config\ConfigUibOverride::getCacheSuffix()
  should return string but return statement is missing.
 - Method Drupal\uib_common_ui\Config\ConfigUibOverride::getCacheableMetadata()
  should return Drupal\Core\Cache\CacheableMetadata but  return statement
  is missing.
parent e5ad038e
No related branches found
No related tags found
1 merge request!8WP143: #1362: ConfigUibOverride missing interface implimentations
Pipeline #273505 passed
...@@ -2,6 +2,7 @@ ...@@ -2,6 +2,7 @@
namespace Drupal\uib_common_ui\Config; namespace Drupal\uib_common_ui\Config;
use Drupal\Core\Cache\CacheableMetadata;
use Drupal\Core\Config\ConfigFactoryOverrideInterface; use Drupal\Core\Config\ConfigFactoryOverrideInterface;
use Drupal\Core\Config\StorageInterface; use Drupal\Core\Config\StorageInterface;
use Drupal\Core\Extension\ModuleHandlerInterface; use Drupal\Core\Extension\ModuleHandlerInterface;
...@@ -33,10 +34,8 @@ class ConfigUibOverride implements ConfigFactoryOverrideInterface { ...@@ -33,10 +34,8 @@ class ConfigUibOverride implements ConfigFactoryOverrideInterface {
*/ */
public function loadOverrides($names): array { public function loadOverrides($names): array {
if (in_array('gin_login.settings', $names, TRUE)) { if (in_array('gin_login.settings', $names, TRUE)) {
// Get the absolute path to the module and append the relative logo path.
$module_path = $this->moduleHandler->getModule('uib_common_ui')->getPath(); $module_path = $this->moduleHandler->getModule('uib_common_ui')->getPath();
$logo_path = $module_path . '/public/image/uib_login_logo.svg'; $logo_path = $module_path . '/public/image/uib_login_logo.svg';
$overrides['gin_login.settings']['logo'] = ['path' => $logo_path]; $overrides['gin_login.settings']['logo'] = ['path' => $logo_path];
} }
...@@ -47,7 +46,7 @@ class ConfigUibOverride implements ConfigFactoryOverrideInterface { ...@@ -47,7 +46,7 @@ class ConfigUibOverride implements ConfigFactoryOverrideInterface {
* {@inheritDoc} * {@inheritDoc}
*/ */
public function getCacheSuffix() { public function getCacheSuffix() {
// @todo Implement getCacheSuffix() method. return '';
} }
/** /**
...@@ -61,7 +60,7 @@ class ConfigUibOverride implements ConfigFactoryOverrideInterface { ...@@ -61,7 +60,7 @@ class ConfigUibOverride implements ConfigFactoryOverrideInterface {
* {@inheritDoc} * {@inheritDoc}
*/ */
public function getCacheableMetadata($name) { public function getCacheableMetadata($name) {
// @todo Implement getCacheableMetadata() method. return new CacheableMetadata();
} }
} }
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment