Sven Berg Ryen authored 3 months ago and Stein Magne Bjorklund committed 3 months ago

Adjusted return types in Person class and ScimConnector to use
ScimRecord|NULL|FALSE to handle all cases uniformly.

Initialized statusCode with 0 and modified getStatusCode to return
int|null in ApiConnectorPluginBase.

Sven Berg Ryen authored 3 months ago and Stein Magne Bjorklund committed 3 months ago

Adjusted return types in Person class and ScimConnector to use
ScimRecord|NULL|FALSE to handle all cases uniformly.

Initialized statusCode with 0 and modified getStatusCode to return
int|null in ApiConnectorPluginBase.

Introduced a new property and method for error messages in the
ApiConnectorPluginBase class.

Updated the Guzzle exception catch block to set the error message
when an exception occurs.

- Useless test that does not work.

Changed the PHPCS target directory to reflect the new path.

Updated DFO synchronization to handle resigned employees by deleting
their nodes and logging an error. Modified relevant API method
signatures to return an array indicating resignation when applicable.

Improved how error messages are logged in ApiConnectorPluginBase. The error message is now logged directly if present, otherwise, the first error message from the response is logged. Also, the logError method is now called with additional parameters to prevent the error message from being displayed.

Stein Magne Bjorklund authored 9 months ago and Are Johannessen committed 9 months ago

- Reported by PHPStan and blocking us from passing level 1.
- https://github.com/phpstan/phpstan-src/pull/1357

improved error handling on connector

See merge request it/lib/drupal/modules/uib-api-connector!2

Fixed indentation

Indent fix second try

third try after misconfiguration of own editor

fix

API Connector updates

See merge request it/lib/drupal/modules/uib-api-connector!1

ref: https://itgit.app.uib.no/it/dpv/dlm/dlp/phplib

Src: https://git.app.uib.no/it/site/w4.uib.no/-/tree/5ee1094a/web/modules/custom/uib_api_connector