Skip to content
Snippets Groups Projects
Commit c85bbda3 authored by Stein Magne Bjorklund's avatar Stein Magne Bjorklund :speech_balloon:
Browse files

Merge branch '1377-wp142-tests-person' into 'main'

WP143 #1377 Refactor title processing logic in setPositionTitleToScimValue

See merge request !5
parents ee0f4d7c 8c3b87a5
No related branches found
No related tags found
1 merge request!5WP143 #1377 Refactor title processing logic in setPositionTitleToScimValue
...@@ -545,11 +545,11 @@ class ScimRecord { ...@@ -545,11 +545,11 @@ class ScimRecord {
private function setPositionTitleToScimValue() :void { private function setPositionTitleToScimValue() :void {
$title = ''; $title = '';
if (!empty($this->data['title']) && $this->data['title']) { if (!empty($this->data['title']) && $this->data['title']) {
// This call is a bit mysterious, but it was done in W3.
$title = ltrim($this->data['title'], '0..9');
// Copying some logic from W3. // Copying some logic from W3.
$title = ucfirst($this->data['title']); $title = ucfirst($title);
$title = str_replace('ii', 'II', $title); $title = str_replace('ii', 'II', $title);
// This call is a bit mysterious, but it was done in W3.
$title = ltrim($title, '0..9');
} }
$this->position = $title ?: ''; $this->position = $title ?: '';
$this->positionEnglish = NULL; $this->positionEnglish = NULL;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment