Merge branch 'GREG-220_fix_crash_on_missing_role_start' into 'master'

GREG-220: Fixing crash on missing role start date in frontend

See merge request !296

frontend/src/interfaces/index.ts

@@ -48,7 +48,7 @@ export type Role = {
   name_en: string
   ou_nb: string
   ou_en: string
-  start_date: Date
+  start_date?: Date
   end_date: Date
   max_days: number
   contact_person_unit: string | null

frontend/src/routes/sponsor/guest/guestRoleInfo/index.test.tsx

@@ -61,8 +61,11 @@ test('Button state correct on load', async () => {
     </Router>
   )
 
-  await waitFor(() => {
-    expect(screen.getByText('button.save')).toBeDisabled()
-    expect(screen.getByText('sponsor.endNow')).toBeEnabled()
-  })
+  await waitFor(
+    () => {
+      expect(screen.getByText('button.save')).toBeDisabled()
+      expect(screen.getByText('sponsor.endNow')).toBeEnabled()
+    },
+    { timeout: 5000 }
+  )
 })

frontend/src/routes/sponsor/guest/guestRoleInfo/index.tsx

@@ -181,7 +181,10 @@ export default function GuestRoleInfo({
       setRole(roleInfo)
       // Set values of date fields to current dates if role exists
       setValue('end_date', roleInfo.end_date)
-      setValue('start_date', roleInfo.start_date)
+      // The start date can be undefined for existing roles that have been imported
+      if (roleInfo.start_date !== undefined) {
+        setValue('start_date', roleInfo.start_date)
+      }
     }
   }
   useEffect(() => {

frontend/src/utils/index.ts

@@ -145,7 +145,7 @@ export function parseRole(role: FetchedRole): Role {
     name_en: role.name_en,
     ou_nb: role.ou_nb,
     ou_en: role.ou_en,
-    start_date: parseISO(role.start_date),
+    start_date: role.start_date == null ? undefined : parseISO(role.start_date),
     end_date: parseISO(role.end_date),
     max_days: role.max_days,
     contact_person_unit: role.contact_person_unit,