From 02a765a5518f4f84d7da4a71432d31fc073daed4 Mon Sep 17 00:00:00 2001 From: Stein Magne Bjorklund <steinmb@smbjorklund.com> Date: Thu, 6 Feb 2025 14:56:10 +0100 Subject: [PATCH] WP143: #1362: ConfigUibOverride missing interface implimentations - Method Drupal\uib_common_ui\Config\ConfigUibOverride::getCacheSuffix() should return string but return statement is missing. - Method Drupal\uib_common_ui\Config\ConfigUibOverride::getCacheableMetadata() should return Drupal\Core\Cache\CacheableMetadata but return statement is missing. --- src/Config/ConfigUibOverride.php | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/Config/ConfigUibOverride.php b/src/Config/ConfigUibOverride.php index 1691174..6a6d4b9 100644 --- a/src/Config/ConfigUibOverride.php +++ b/src/Config/ConfigUibOverride.php @@ -2,6 +2,7 @@ namespace Drupal\uib_common_ui\Config; +use Drupal\Core\Cache\CacheableMetadata; use Drupal\Core\Config\ConfigFactoryOverrideInterface; use Drupal\Core\Config\StorageInterface; use Drupal\Core\Extension\ModuleHandlerInterface; @@ -33,10 +34,8 @@ class ConfigUibOverride implements ConfigFactoryOverrideInterface { */ public function loadOverrides($names): array { if (in_array('gin_login.settings', $names, TRUE)) { - // Get the absolute path to the module and append the relative logo path. $module_path = $this->moduleHandler->getModule('uib_common_ui')->getPath(); $logo_path = $module_path . '/public/image/uib_login_logo.svg'; - $overrides['gin_login.settings']['logo'] = ['path' => $logo_path]; } @@ -47,7 +46,7 @@ class ConfigUibOverride implements ConfigFactoryOverrideInterface { * {@inheritDoc} */ public function getCacheSuffix() { - // @todo Implement getCacheSuffix() method. + return ''; } /** @@ -61,7 +60,7 @@ class ConfigUibOverride implements ConfigFactoryOverrideInterface { * {@inheritDoc} */ public function getCacheableMetadata($name) { - // @todo Implement getCacheableMetadata() method. + return new CacheableMetadata(); } } -- GitLab