From e3b718e9b0e3d41179a375a26884076ccf731e33 Mon Sep 17 00:00:00 2001
From: Andreas Tolfsen <andretol@usit.uio.no>
Date: Thu, 19 Aug 2021 14:48:50 +0200
Subject: [PATCH] greg.api.filters: use explicit symbol imports
Mostly a visual improvement, but instead of importing the entire
django_filters.rest_framework module we make the dependency situation
clearer by importing specific symbols.
Fixes: GREG-20
---
greg/api/filters.py | 22 +++++++++++++++-------
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/greg/api/filters.py b/greg/api/filters.py
index 14ef355e..86465b1d 100644
--- a/greg/api/filters.py
+++ b/greg/api/filters.py
@@ -1,18 +1,26 @@
-from django_filters import rest_framework as filters
+from django_filters.rest_framework import (
+ BaseInFilter,
+ BooleanFilter,
+ FilterSet,
+)
-from greg.models import Person, PersonRole, PersonIdentity
+from greg.models import (
+ Person,
+ PersonRole,
+ PersonIdentity,
+)
-class PersonRoleFilter(filters.FilterSet):
- type = filters.BaseInFilter(field_name="role__type", lookup_expr="in")
+class PersonRoleFilter(FilterSet):
+ type = BaseInFilter(field_name="role__type", lookup_expr="in")
class Meta:
model = PersonRole
fields = ["type"]
-class PersonFilter(filters.FilterSet):
- verified = filters.BooleanFilter(
+class PersonFilter(FilterSet):
+ verified = BooleanFilter(
field_name="person__verified_by_id", lookup_expr="isnull", exclude=True
)
@@ -21,7 +29,7 @@ class PersonFilter(filters.FilterSet):
fields = ["first_name", "last_name", "verified"]
-class PersonIdentityFilter(filters.FilterSet):
+class PersonIdentityFilter(FilterSet):
class Meta:
model = PersonIdentity
fields = ["type", "verified_by_id"]
--
GitLab