From dd8a01b44f6a5d4fffe0b02904434a23d66de02c Mon Sep 17 00:00:00 2001
From: Andreas Tolfsen <andretol@usit.uio.no>
Date: Thu, 15 Jul 2021 17:34:34 +0200
Subject: [PATCH] greg: fix various unused imports
All reported by pylint.
Fixes: GREG-16
---
greg/api/serializers/role.py | 4 ++--
greg/api/views/role.py | 3 ---
greg/apps.py | 2 +-
greg/tests/test_api_person.py | 9 +++++----
greg/urls.py | 1 -
5 files changed, 8 insertions(+), 11 deletions(-)
diff --git a/greg/api/serializers/role.py b/greg/api/serializers/role.py
index 06f9eaf4..3fd2d03d 100644
--- a/greg/api/serializers/role.py
+++ b/greg/api/serializers/role.py
@@ -1,9 +1,9 @@
-from rest_framework import fields, serializers
+from rest_framework.serializers import ModelSerializer
from greg.models import Role
-class RoleSerializer(serializers.ModelSerializer):
+class RoleSerializer(ModelSerializer):
class Meta:
model = Role
fields = "__all__"
diff --git a/greg/api/views/role.py b/greg/api/views/role.py
index 80de78c3..fbfce2fd 100644
--- a/greg/api/views/role.py
+++ b/greg/api/views/role.py
@@ -1,7 +1,4 @@
-from django_filters import rest_framework as filters
-
from rest_framework import viewsets
-from rest_framework.schemas.openapi import AutoSchema
from greg.api.pagination import PrimaryKeyCursorPagination
from greg.api.serializers.role import RoleSerializer
diff --git a/greg/apps.py b/greg/apps.py
index 6d47fa17..d3307bd4 100644
--- a/greg/apps.py
+++ b/greg/apps.py
@@ -7,4 +7,4 @@ class GregAppConfig(AppConfig):
verbose_name = _("Greg")
def ready(self):
- import greg.signals
+ import greg.signals # pylint: disable=unused-import
diff --git a/greg/tests/test_api_person.py b/greg/tests/test_api_person.py
index 6a40baf6..7f66557a 100644
--- a/greg/tests/test_api_person.py
+++ b/greg/tests/test_api_person.py
@@ -1,12 +1,13 @@
from django.contrib.auth import get_user_model
-from django.test import TestCase
-from django.utils.dateparse import parse_datetime
from rest_framework import status
from rest_framework.authtoken.models import Token
from rest_framework.reverse import reverse
-from rest_framework.test import APIClient, APITestCase
+from rest_framework.test import (
+ APIClient,
+ APITestCase,
+)
-from greg.models import Person, PersonRole, Role
+from greg.models import Person
class GregAPITestCase(APITestCase):
diff --git a/greg/urls.py b/greg/urls.py
index 44f0031d..aae406a6 100644
--- a/greg/urls.py
+++ b/greg/urls.py
@@ -14,7 +14,6 @@ Including another URLconf
2. Add a URL to urlpatterns: path('blog/', include('blog.urls'))
"""
from typing import List
-from django.contrib import admin
from django.urls import path, include
from django.urls.resolvers import URLResolver
--
GitLab