From d3b74e1718e19af12de6a2d2ec670d4862c64497 Mon Sep 17 00:00:00 2001
From: Marte Fossum <marte.fossum@usit.uio.no>
Date: Wed, 11 Oct 2023 14:49:25 +0200
Subject: [PATCH] Fix id_type name given to cerebrum api
---
gregui/tests/api/views/test_identity.py | 4 ++--
iga/tests/test_uio.py | 8 ++++----
iga/uio.py | 4 ++--
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/gregui/tests/api/views/test_identity.py b/gregui/tests/api/views/test_identity.py
index 3c59514d..efb1907e 100644
--- a/gregui/tests/api/views/test_identity.py
+++ b/gregui/tests/api/views/test_identity.py
@@ -40,7 +40,7 @@ def test_identity_check_nonexisting_fnr(
"""Verify that identitycheck endpoint checks iga when queried"""
settings.IGA_CHECK = True
requests_mock.get(
- "http://example.com/cerebrum/v1/search/persons/external-ids?id_type=NO_BIRTHNO&external_id=12345612345",
+ "http://example.com/cerebrum/v1/search/persons/external-ids?id_type=norwegianNationalId&external_id=12345612345",
json={"external_ids": []},
)
log_in(user_sponsor)
@@ -56,7 +56,7 @@ def test_identity_check_existing_fnr(
"""Verify that identitycheck endpoint checks iga when queried"""
settings.IGA_CHECK = True
requests_mock.get(
- "http://example.com/cerebrum/v1/search/persons/external-ids?id_type=NO_BIRTHNO&external_id=12345612345",
+ "http://example.com/cerebrum/v1/search/persons/external-ids?id_type=norwegianNationalId&external_id=12345612345",
json={
"external_ids": [
{
diff --git a/iga/tests/test_uio.py b/iga/tests/test_uio.py
index 24cd55d7..d81e6cb7 100644
--- a/iga/tests/test_uio.py
+++ b/iga/tests/test_uio.py
@@ -5,7 +5,7 @@ from ..uio import UioCerebrum
def test_uio_search_hit(requests_mock):
requests_mock.get(
- "http://example.com/cerebrum/v1/search/persons/external-ids?id_type=NO_BIRTHNO&external_id=123",
+ "http://example.com/cerebrum/v1/search/persons/external-ids?id_type=norwegianNationalId&external_id=123",
json={
"external_ids": [
{
@@ -18,7 +18,7 @@ def test_uio_search_hit(requests_mock):
},
)
requests_mock.get(
- "http://example.com/cerebrum/v1/search/persons/external-ids?id_type=PASSNR&external_id=12345",
+ "http://example.com/cerebrum/v1/search/persons/external-ids?id_type=passportNumber&external_id=12345",
json={
"external_ids": [
{
@@ -60,11 +60,11 @@ def test_uio_search_hit(requests_mock):
def test_uio_search_miss(requests_mock):
"""Verify no matches returns empty list"""
requests_mock.get(
- "http://example.com/cerebrum/v1/search/persons/external-ids?id_type=NO_BIRTHNO&external_id=123",
+ "http://example.com/cerebrum/v1/search/persons/external-ids?id_type=norwegianNationalId&external_id=123",
json={"external_ids": []},
)
requests_mock.get(
- "http://example.com/cerebrum/v1/search/persons/external-ids?id_type=PASSNR&external_id=12345",
+ "http://example.com/cerebrum/v1/search/persons/external-ids?id_type=passportNumber&external_id=12345",
json={"external_ids": []},
)
diff --git a/iga/uio.py b/iga/uio.py
index 93abc939..6bb9ddb2 100644
--- a/iga/uio.py
+++ b/iga/uio.py
@@ -13,8 +13,8 @@ class UioCerebrum(IgaImplementation):
def __init__(self, config) -> None:
self.client = CerebrumClient(**config)
self.idtype2cerebrum = {
- Identity.IdentityType.NORWEGIAN_NATIONAL_ID_NUMBER: "NO_BIRTHNO",
- Identity.IdentityType.PASSPORT_NUMBER: "PASSNR",
+ Identity.IdentityType.NORWEGIAN_NATIONAL_ID_NUMBER: "norwegianNationalId",
+ Identity.IdentityType.PASSPORT_NUMBER: "passportNumber",
}
def extid_search(
--
GitLab