diff --git a/gregui/api/views/userinfo.py b/gregui/api/views/userinfo.py index 8abf0c9a0cc83eaf56b270583f3c1a3c9e93259a..aef0b9327e13f9f5e6194045db0fb33545b86bc0 100644 --- a/gregui/api/views/userinfo.py +++ b/gregui/api/views/userinfo.py @@ -52,7 +52,6 @@ class UserInfoView(APIView): "person_id": person_id, } person = user_profile.person - roles = person.roles if person: content.update( { @@ -62,27 +61,28 @@ class UserInfoView(APIView): "mobile_phone": person.mobile_phone, } ) - if roles: - content.update( - { - "roles": [ - { - "ou_name_nb": role.orgunit_id.name_nb, - "ou_name_en": role.orgunit_id.name_en, - "role_name_nb": role.type.name_nb, - "role_name_en": role.type.name_en, - "start": role.start_date, - "end": role.end_date, - "comments": role.comments, - "sponsor": { - "first_name": role.sponsor_id.first_name, - "last_name": role.sponsor_id.last_name, - }, - } - for role in roles.all() - ], - } - ) + roles = person.roles + if roles: + content.update( + { + "roles": [ + { + "ou_name_nb": role.orgunit_id.name_nb, + "ou_name_en": role.orgunit_id.name_en, + "role_name_nb": role.type.name_nb, + "role_name_en": role.type.name_en, + "start": role.start_date, + "end": role.end_date, + "comments": role.comments, + "sponsor": { + "first_name": role.sponsor_id.first_name, + "last_name": role.sponsor_id.last_name, + }, + } + for role in roles.all() + ], + } + ) return Response(content) # Invitation cookie, allow access