From a0ea6de7787c02410fc73e06b2d818a4e6e6a048 Mon Sep 17 00:00:00 2001
From: Sivert Kronen Hatteberg <skh@uio.no>
Date: Mon, 15 Nov 2021 10:57:40 +0100
Subject: [PATCH] Remove check on emplyee status.
We trust the cerebrum data. There are leaders at UiO that are not
employees.
---
.../commands/import_sponsors_from_cerebrum.py | 15 ---------------
1 file changed, 15 deletions(-)
diff --git a/greg/management/commands/import_sponsors_from_cerebrum.py b/greg/management/commands/import_sponsors_from_cerebrum.py
index 7139e115..6b720771 100644
--- a/greg/management/commands/import_sponsors_from_cerebrum.py
+++ b/greg/management/commands/import_sponsors_from_cerebrum.py
@@ -33,17 +33,6 @@ class Command(BaseCommand):
super().__init__(*args, **kwargs)
self.client = CerebrumClient(**settings.CEREBRUM_CLIENT)
- def _has_active_dfo_aff(self, person_id: str):
- """Check that a person has a valid employee affiliation from DFØ."""
-
- dfo_employee_affs = [
- x
- for x in self.client.get_person_affiliations(person_id)
- if x.source_system == "DFO_SAP" and x.affiliation == "ANSATT"
- ]
-
- return len(dfo_employee_affs) > 0
-
def _upsert_sponsor_unit_link(self, sponsor: Sponsor, unit: OrganizationalUnit):
"""Ensure a link between sponsor and unit."""
sunit, created = SponsorOrganizationalUnit.objects.get_or_create(
@@ -95,10 +84,6 @@ class Command(BaseCommand):
logger.warning("cerebrum_person_missing", cerebrum_person_id=person_id)
return None
- if not self._has_active_dfo_aff(person_id):
- logger.warning("cerebrum_not_an_employee", cerebrum_person_id=person_id)
- return None
-
feide_id = self._get_feide_id(person_id)
if not feide_id:
logger.warning("cerebrum_no_primary_account", cerebrum_person_id=person_id)
--
GitLab