From 85018e874e39e782ea00a89e6da1b31bf0739133 Mon Sep 17 00:00:00 2001
From: Tore Brede <Tore.Brede@uib.no>
Date: Tue, 8 Mar 2022 11:57:52 +0100
Subject: [PATCH] GREG-208: Adding a test
---
greg/tests/api/test_person.py | 39 ++++++++++++++++++++++++++++++
gregui/api/serializers/identity.py | 3 ---
2 files changed, 39 insertions(+), 3 deletions(-)
diff --git a/greg/tests/api/test_person.py b/greg/tests/api/test_person.py
index 87877314..cd958a88 100644
--- a/greg/tests/api/test_person.py
+++ b/greg/tests/api/test_person.py
@@ -7,6 +7,8 @@ from rest_framework.reverse import reverse
from rest_framework.status import HTTP_200_OK
from rest_framework.test import APIClient
+from django.utils import timezone
+
from greg.models import (
Consent,
Identity,
@@ -594,3 +596,40 @@ def test_person_consent_add_invalid_choice_fails(
# No consent should have been added to the person
consents_for_person = client.get(url).json()["results"]
assert len(consents_for_person) == 0
+
+
+@pytest.mark.django_db
+def test_identity_post_fails_if_duplicate(client, person, person_foo):
+ response = client.get(
+ reverse("v1:person_identity-list", kwargs={"person_id": person.id})
+ )
+ results = response.json()["results"]
+ assert len(results) == 0
+
+ Identity.objects.create(
+ person=person_foo,
+ type=Identity.IdentityType.NORWEGIAN_NATIONAL_ID_NUMBER,
+ source="Test source",
+ value="12345678901",
+ verified_at=timezone.now() - datetime.timedelta(days=205),
+ )
+
+ data = {
+ "type": Identity.IdentityType.NORWEGIAN_NATIONAL_ID_NUMBER,
+ "source": "Test source",
+ "value": person_foo.fnr.value,
+ }
+ response = client.post(
+ reverse("v1:person_identity-list", kwargs={"person_id": person.id}),
+ data=data,
+ )
+
+ # The request should fail
+ assert response.status_code == status.HTTP_400_BAD_REQUEST
+
+ response = client.get(
+ reverse("v1:person_identity-list", kwargs={"person_id": person.id})
+ )
+ results = response.json()["results"]
+ # No national ID should have been added
+ assert len(results) == 0
diff --git a/gregui/api/serializers/identity.py b/gregui/api/serializers/identity.py
index 4d792987..6395cf12 100644
--- a/gregui/api/serializers/identity.py
+++ b/gregui/api/serializers/identity.py
@@ -48,9 +48,6 @@ class IdentitySerializer(serializers.ModelSerializer):
Note: Get requests do not use this method, making it safe.
"""
-
- # TODO Check for duplicate value
-
# Prevent nin verification. (This will only trigger if someone is posting the
# requests themselves. The frontend has its own setting disabling the button
# used against this endpoint.)
--
GitLab