From 6b139807d12299433b739bde4c9d7bb435f1ba63 Mon Sep 17 00:00:00 2001
From: Jonas Braathen <jonas.braathen@usit.uio.no>
Date: Fri, 3 Sep 2021 09:40:54 +0200
Subject: [PATCH] Fix linting errors
---
greg/api/serializers/person.py | 6 +++---
greg/tests/api/test_person.py | 1 -
greg/tests/models/test_person.py | 2 +-
3 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/greg/api/serializers/person.py b/greg/api/serializers/person.py
index 9310fba5..e5f52711 100644
--- a/greg/api/serializers/person.py
+++ b/greg/api/serializers/person.py
@@ -39,10 +39,10 @@ class IdentitySerializer(serializers.ModelSerializer):
# If the type is a specific ID type, then duplicates are not expected
return Identity.objects.filter(type=identity_type).filter(value=value).exists()
- def validate(self, data):
- if self.is_duplicate(data["type"], data["value"]):
+ def validate(self, attrs):
+ if self.is_duplicate(attrs["type"], attrs["value"]):
raise ValidationError("Identity already exists")
- return data
+ return attrs
class ConsentTypeSerializerBrief(serializers.ModelSerializer):
diff --git a/greg/tests/api/test_person.py b/greg/tests/api/test_person.py
index aac8cf24..2a8fe251 100644
--- a/greg/tests/api/test_person.py
+++ b/greg/tests/api/test_person.py
@@ -2,7 +2,6 @@ import datetime
from typing import Dict
import pytest
-from django.core.exceptions import ValidationError
from rest_framework import status
from rest_framework.reverse import reverse
from rest_framework.status import HTTP_200_OK
diff --git a/greg/tests/models/test_person.py b/greg/tests/models/test_person.py
index 5c4992ed..2a2891fc 100644
--- a/greg/tests/models/test_person.py
+++ b/greg/tests/models/test_person.py
@@ -1,4 +1,4 @@
-from datetime import datetime, timedelta
+from datetime import timedelta
from functools import partial
import pytest
--
GitLab