diff --git a/greg/api/serializers/person.py b/greg/api/serializers/person.py index 9310fba5b924ef2198db8d36e6b34e2c552cdbc8..e5f52711164793199d3f755ddc917972e1417332 100644 --- a/greg/api/serializers/person.py +++ b/greg/api/serializers/person.py @@ -39,10 +39,10 @@ class IdentitySerializer(serializers.ModelSerializer): # If the type is a specific ID type, then duplicates are not expected return Identity.objects.filter(type=identity_type).filter(value=value).exists() - def validate(self, data): - if self.is_duplicate(data["type"], data["value"]): + def validate(self, attrs): + if self.is_duplicate(attrs["type"], attrs["value"]): raise ValidationError("Identity already exists") - return data + return attrs class ConsentTypeSerializerBrief(serializers.ModelSerializer): diff --git a/greg/tests/api/test_person.py b/greg/tests/api/test_person.py index aac8cf24a1c88cede49baed4f5061514dc000f93..2a8fe2516c32f35786bb75568fdbcab81022407c 100644 --- a/greg/tests/api/test_person.py +++ b/greg/tests/api/test_person.py @@ -2,7 +2,6 @@ import datetime from typing import Dict import pytest -from django.core.exceptions import ValidationError from rest_framework import status from rest_framework.reverse import reverse from rest_framework.status import HTTP_200_OK diff --git a/greg/tests/models/test_person.py b/greg/tests/models/test_person.py index 5c4992ed7c776908bda5f1676536dd46ecfe94bc..2a2891fceefe9a1c2877e3796eee5b95e3d81791 100644 --- a/greg/tests/models/test_person.py +++ b/greg/tests/models/test_person.py @@ -1,4 +1,4 @@ -from datetime import datetime, timedelta +from datetime import timedelta from functools import partial import pytest