From 24f73b60d7097bec8382b75df1d7f2bbc719c82b Mon Sep 17 00:00:00 2001
From: Jonas Braathen <jonas.braathen@usit.uio.no>
Date: Tue, 19 Oct 2021 16:10:02 +0200
Subject: [PATCH] Fix typing and linting errors
---
greg/management/commands/notification_publisher.py | 1 -
greg/management/commands/task_scheduler.py | 1 +
greg/signals.py | 6 +++---
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/greg/management/commands/notification_publisher.py b/greg/management/commands/notification_publisher.py
index 3ea72587..f775b339 100644
--- a/greg/management/commands/notification_publisher.py
+++ b/greg/management/commands/notification_publisher.py
@@ -49,7 +49,6 @@ def create_cloud_event_payload(n: Notification) -> str:
and source, i.e no.local.greg.person.add
"""
- object_type = camel_to_snake(n.object_type)
content: dict[str, Union[str, dict[str, str]]] = {
"id": str(n.id),
"source": f"greg:{settings.INSTANCE_NAME}:{settings.ENVIRONMENT}",
diff --git a/greg/management/commands/task_scheduler.py b/greg/management/commands/task_scheduler.py
index ac5a6a6e..29fe967e 100644
--- a/greg/management/commands/task_scheduler.py
+++ b/greg/management/commands/task_scheduler.py
@@ -10,6 +10,7 @@ from greg.schedule import ExpiringRolesNotification
logging.config.dictConfig(settings.LOGGING)
logger = logging.getLogger(__name__)
+
class Command(BaseCommand):
"""
This command starts a basic task runner. All tasks it is supposed to
diff --git a/greg/signals.py b/greg/signals.py
index 20110bc8..3f52d861 100644
--- a/greg/signals.py
+++ b/greg/signals.py
@@ -1,6 +1,6 @@
import time
import logging
-from typing import Dict
+from typing import Dict, Union
from django.db import models
from django.dispatch import receiver
@@ -165,8 +165,8 @@ def m2m_changed_notification_callback(
)
-def _create_metadata(instance) -> Dict:
- meta = {}
+def _create_metadata(instance) -> Dict[str, Union[int, str]]:
+ meta: Dict[str, Union[int, str]] = {}
if isinstance(instance, Person):
meta["person_id"] = instance.id
elif isinstance(instance, Role):
--
GitLab