diff --git a/greg/api/filters.py b/greg/api/filters.py index bec4937c680ea9239fc5059a5441703dc760b74c..1c97b58f1196c7fa0a8bf2fee59c331727d12df8 100644 --- a/greg/api/filters.py +++ b/greg/api/filters.py @@ -38,9 +38,9 @@ class PersonFilter(FilterSet): return queryset.annotate( active=Case( When( - Q(person_roles__start_date__isnull=True) - | Q(person_roles__start_date__lte=datetime_now), - person_roles__end_date__gte=datetime_now, + Q(roles__start_date__isnull=True) + | Q(roles__start_date__lte=datetime_now), + roles__end_date__gte=datetime_now, then=True, ), default=False, diff --git a/greg/tests/api/test_person.py b/greg/tests/api/test_person.py index e94d962ac9fa962193c67fd4bc12d6666d93b170..df7475e6dc9799f62d1f67c004081fe1bd44514c 100644 --- a/greg/tests/api/test_person.py +++ b/greg/tests/api/test_person.py @@ -427,13 +427,13 @@ def test_filter_active_includes_person_with_active_role( person_foo: Person, sponsor_guy: Sponsor, unit_foo: OrganizationalUnit, - role_test_guest: Role, + role_type_test_guest: RoleType, ): date_today = datetime.date.today() Role.objects.create( person=person_foo, - role=role_test_guest, + type=role_type_test_guest, end_date=date_today + datetime.timedelta(days=1), registered_by=sponsor_guy, unit=unit_foo,